textview: Properly delete anchored children

When we remove anchors with widgets from the text
buffer, we used to call gtk_widget_destroy(), which
indirectly called gtk_container_remove() which cleared
the child properly. When gtk_widget_destroy() was
removed, we replaced the calls with gtk_widget_unparent(),
but that is not enough. Explicitly call
gtk_text_view_remove() instead - we know the parent
is a text view.

diff --git a/gtk/gtktextchild.c b/gtk/gtktextchild.c
index f569a503bdad4426b89d5c6c26208081dd020dbc..4d5e30e44fceae22a98ca70fcba5e4b67d04bec8 100644 (file)
--- a/gtk/gtktextchild.c
+++ b/gtk/gtktextchild.c
@@ -236,8 +236,8 @@ child_segment_delete_func (GtkTextLineSegment *seg,
     {
       GtkWidget *child = tmp_list->data;
 
-      gtk_widget_unparent (child);
-      
+      gtk_text_view_remove (GTK_TEXT_VIEW (gtk_widget_get_parent (child)), child);
+
       tmp_list = tmp_list->next;
     }